Ticket #234 (new feature)

Opened 1 year ago

Last modified 1 year ago

Unify useable/eatable/spell code

Reported by: takkaria Assigned to:
Milestone: 3.2.0 Version:
Keywords: Cc:

Description

Create effects.c, move everything into there. Eases maintenance.

Attachments

Change History

07/10/07 10:02:07 changed by takkaria

  • status changed from new to assigned.

07/10/07 10:03:13 changed by takkaria

first commit [317]:

  • moves food over to effects.c
  • moves item nutrition info to lib/object.txt

issues:

  • doesn't print any use information on the "examine" screen

07/10/07 11:11:59 changed by takkaria

[318] moves scrolls to effects.c

07/10/07 18:11:47 changed by takkaria

  • [319] moved rings across and added description code
  • [320] moved artifacts across and further improved description code

current issues:

  • items are described to you regardless of ID status.
  • rods will not use charge

to bear in mind when moving rods across: make sure they don't give type away by not always prompting for a direction

07/10/07 20:39:32 changed by takkaria

[321] fixes things that requiring aiming before use, moves the effect code from taking an object to taking an effect type, adds proper display of artifact activation messages, and moves potions to the new code.

Also unifies some bad effects between mushrooms and potions; change duration dice of some effects to more aesethically pleasing.

new issues:

  • descriptions need proof-reading
  • some effects may still be using "break;" rather than "return TRUE;"

07/12/07 16:10:57 changed by takkaria

report: "Attempting to read the scroll of trap detection on the ground in my square gives the message "Oops. That object cannot be activated." Other scrolls seem OK. I don't know if all trap detection scrolls ause this issue or only this particular one, since I normally use the spell."

07/12/07 18:42:58 changed by takkaria

[325] finishes off objects for now, including all the issues noted above. Spells yet to be done.

07/31/07 12:11:33 changed by takkaria

  • owner deleted.
  • status changed from assigned to new.

assigning to no-one, since I'm not working on this for a while


Add/Change #234 (Unify useable/eatable/spell code)