Ticket #552 (closed bug: fixed)

Opened 5 months ago

Last modified 2 months ago

Highscores busted

Reported by: takkaria Assigned to: takkaria
Milestone: 3.1.0 Version: dev
Keywords: Cc:

Description

See discussion at http://angband.oook.cz/forum/showthread.php?t=662

It would be good to just rewrite this code, I think.

Attachments

score.diff (22.4 kB) - added by takkaria on 06/02/08 21:31:31.
First go at fixing this up

Change History

06/02/08 21:31:06 changed by takkaria

  • owner set to takkaria.
  • status changed from new to assigned.

06/02/08 21:31:31 changed by takkaria

  • attachment score.diff added.

First go at fixing this up

06/02/08 21:40:14 changed by takkaria

Attached is a patch which is a significant rewrite of the scorefile handling code. Instead of making use of file-seek and incremental reading operations, it instead prefers to read all highscores into a buffer of 12.5kB, operate with the data entirely in memory, and then write it out (if necessary).

This simplifies an amount of code. As a result of this, the logic code that deals with writing the scorefile is more clearly visible and has had several corrections.

Another good thing about this code is also that it will make future modifications to the highscore format really very easy.

06/28/08 05:58:07 changed by takkaria

  • status changed from assigned to closed.
  • resolution set to fixed.

see r965

Add/Change #552 (Highscores busted)




Action